Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: React 19 messes with "Mentions" example #5846

Closed
1 task done
CHE1RON opened this issue Nov 19, 2024 · 4 comments
Closed
1 task done

[Bug]: React 19 messes with "Mentions" example #5846

CHE1RON opened this issue Nov 19, 2024 · 4 comments
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug

Comments

@CHE1RON
Copy link

CHE1RON commented Nov 19, 2024 •
edited
Loading

Affected Packages

extension-mention

Version(s)

2.9.1

Bug Description

When React v19 is installed, the example over at https://tiptap.dev/docs/editor/extensions/nodes/mention stops working (= ref not being passed correctly) due to changes to the way refs are handled in general it would seem - and ref cannot be passed to ReactRenderer 🤔

When using forwardRef everything works as expected though.

Browser Used

Chrome

Code Example URL

No response

Expected Behavior

Example works just as before

Additional Context (Optional)

Clicking on a list entry still works

Dependency Updates

  • Yes, I've updated all my dependencies.
@CHE1RON CHE1RON added Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug labels Nov 19, 2024
nperez0111 added a commit that referenced this issue Nov 20, 2024
@nperez0111
fix(react): improve React 19 compatibility by using JSX transform ins…
f3307ad 
…tead #5846
@nperez0111 nperez0111 mentioned this issue Nov 20, 2024
Merged
5 tasks
@nperez0111
Copy link
Contributor

Thanks for pointing this out @CHE1RON I think I've resolved it & will push a new release

@CHE1RON
Copy link
Author

CHE1RON commented Nov 20, 2024

That's great to hear, and let me say I'm really impressed by your speed ⚡ 🏆

nperez0111 added a commit that referenced this issue Nov 20, 2024
@nperez0111
fix(react): improve React 19 compatibility by using JSX transform ins…
5eee480 
…tead #5846 (#5848)
This was referenced Nov 20, 2024
Open
Merged
@nperez0111
Copy link
Contributor

Released with 2.10.0

@CHE1RON
Copy link
Author

CHE1RON commented Nov 20, 2024

I will test & report back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nperez0111 @CHE1RON