Skip to content

Commit

Permalink
refactor(global): remove yarn in favor for npm
Browse files Browse the repository at this point in the history
  • Loading branch information
bdbch committed May 13, 2022
1 parent 5bc7708 commit 80de6cd
Show file tree
Hide file tree
Showing 9 changed files with 73 additions and 7,856 deletions.
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ body:
- type: checkboxes
attributes:
label: Did you update your dependencies?
description: "Use `yarn upgrade-interactive` to update your dependencies."
description: "Use `npm update` to update your dependencies."
options:
- label: Yes, I’ve updated my dependencies to use the latest version of all packages.
required: true
Expand Down
18 changes: 9 additions & 9 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,16 +38,16 @@ jobs:
path: |
**/node_modules
/home/runner/.cache/Cypress
key: ${{ runner.os }}-node-${{ matrix.node-version }}-${{ hashFiles('**/yarn.lock') }}
key: ${{ runner.os }}-node-${{ matrix.node-version }}-${{ hashFiles('**/package-lock.json') }}

- name: Install dependencies
id: install-dependencies
if: steps.cache.outputs.cache-hit != 'true'
run: yarn install
run: npm install

# - name: Fix code style linting errors
# id: lint-fix
# run: yarn lint:fix
# run: npm run lint:fix
# continue-on-error: true
#
# - name: Commit fixed linting errors
Expand All @@ -58,7 +58,7 @@ jobs:

- name: Lint code
id: lint
run: yarn lint
run: npm run lint

- name: Send Slack notifications
uses: act10ns/slack@v1
Expand Down Expand Up @@ -91,8 +91,8 @@ jobs:
id: cypress
uses: cypress-io/github-action@v2
with:
cache-key: ${{ runner.os }}-node-${{ matrix.node-version }}-${{ hashFiles('**/yarn.lock') }}
start: yarn start
cache-key: ${{ runner.os }}-node-${{ matrix.node-version }}-${{ hashFiles('**/package-lock.json') }}
start: npm run start
wait-on: 'http://localhost:3000'
project: ./tests
browser: chrome
Expand Down Expand Up @@ -150,16 +150,16 @@ jobs:
path: |
**/node_modules
/home/runner/.cache/Cypress
key: ${{ runner.os }}-node-${{ matrix.node-version }}-${{ hashFiles('**/yarn.lock') }}
key: ${{ runner.os }}-node-${{ matrix.node-version }}-${{ hashFiles('**/package-lock.json') }}

- name: Install dependencies
id: install-dependencies
if: steps.cache.outputs.cache-hit != 'true'
run: yarn install
run: npm install

- name: Try to build the packages
id: build-packages
run: yarn build:ci
run: npm run build:ci

- name: Send Slack notifications
uses: act10ns/slack@v1
Expand Down
2 changes: 1 addition & 1 deletion demos/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"private": true,
"scripts": {
"start": "vite --host",
"build": "yarn ts && vite build",
"build": "npm run ts && vite build",
"ts": "tsc --project tsconfig.base.json --noEmit && tsc --project tsconfig.react.json --noEmit && tsc --project tsconfig.vue-2.json --noEmit && tsc --project tsconfig.vue-3.json --noEmit"
},
"dependencies": {
Expand Down
10 changes: 5 additions & 5 deletions docs/overview/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,19 +20,19 @@ tiptap would be nothing without its lively community. Contributions have always
Make sure to open an issue and outline your idea first. We’ll get back to you quickly and let you know if there is a chance we can merge your contribution.

## Set up the development environment
It’s not too hard to tinker around with the official repository. You’ll need [Git](https://github.com/git-guides/install-git), [Node](https://nodejs.org/en/download/) and [Yarn](https://classic.yarnpkg.com/en/docs/install/#mac-stable) installed. Here is what you need to do then:
It’s not too hard to tinker around with the official repository. You’ll need [Git](https://github.com/git-guides/install-git), [Node and NPM](https://nodejs.org/en/download/) installed. Here is what you need to do then:

1. Copy the code to your local machine: `$ git clone [email protected]:ueberdosis/tiptap.git`
2. Install dependencies: `$ yarn install`
3. Start the development environment: `$ yarn start`
2. Install dependencies: `$ npm install`
3. Start the development environment: `$ npm run start`
4. Open http://localhost:3000 in your favorite browser.
5. Start playing around!

## Our code style
There is an eslint config that ensures a consistent code style. To check for errors, run `$ yarn run lint`. That’ll be checked when you send a pull request, too. Make sure it’s passing, before sending a pull request.
There is an eslint config that ensures a consistent code style. To check for errors, run `$ npm run lint`. That’ll be checked when you send a pull request, too. Make sure it’s passing, before sending a pull request.

## Testing for errors
Your pull request will automatically execute all our existing tests. Make sure that they all pass, before sending a pull request. Run all tests locally with `$ yarn run test` or run single tests (e. g. when writing new ones) with `$ yarn run test:open`.
Your pull request will automatically execute all our existing tests. Make sure that they all pass, before sending a pull request. Run all tests locally with `$ npm run test` or run single tests (e. g. when writing new ones) with `$ npm run test:open`.

## Further questions
Any further questions? Create a new issue or discussion in the repository. We’ll get back to you.
14 changes: 2 additions & 12 deletions docs/overview/upgrade-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,19 +35,9 @@ npm install @tiptap/vue-2 @tiptap/starter-kit
```

## Keep Tiptap v2 up to date
We are constantly releasing updates to Tiptap. Did you know there’s an easy-to-use command to update your dependencies with Yarn?
We are constantly releasing updates to Tiptap.

```bash
yarn upgrade-interactive
```

You can add the `--latest` flag, to show all possible upgrades – even if they don’t follow the versioning you’ve set in your package.json.

```bash
yarn upgrade-interactive --latest
```

Unfortunately, for npm there is no integrated tool, but you can use the `npm-check` package:
Unfortunately, for npm there is no integrated tool to easily update your dependencies, but you can use the `npm-check` package:

```bash
npm install -g npm-check
Expand Down
3 changes: 1 addition & 2 deletions lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,11 @@
"packages": [
"packages/*"
],
"npmClient": "yarn",
"version": "independent",
"useWorkspaces": false,
"command": {
"publish": {
"conventionalCommits": true
"conventionalCommits": true
}
}
}
78 changes: 47 additions & 31 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 80de6cd

Please sign in to comment.