fix(bubble-menu): prevent null pointer exception in BubbleMenu (#5842)

ueberdosis · Nov 19, 2024 · 1959eb5 · 1959eb5
1 parent 2ea807d
commit 1959eb5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/.changeset/seven-hats-thank.md b/.changeset/seven-hats-thank.md
@@ -0,0 +1,5 @@
+---
+"@tiptap/extension-bubble-menu": patch
+---
+
+Fix a potential null pointer exception
diff --git a/packages/extension-bubble-menu/src/bubble-menu-plugin.ts b/packages/extension-bubble-menu/src/bubble-menu-plugin.ts
@@ -266,14 +266,16 @@ export class BubbleMenuView {
           if (isNodeSelection(state.selection)) {
             let node = view.nodeDOM(from) as HTMLElement
 
-            const nodeViewWrapper = node.dataset.nodeViewWrapper ? node : node.querySelector('[data-node-view-wrapper]')
+            if (node) {
+              const nodeViewWrapper = node.dataset.nodeViewWrapper ? node : node.querySelector('[data-node-view-wrapper]')
 
-            if (nodeViewWrapper) {
-              node = nodeViewWrapper.firstChild as HTMLElement
-            }
+              if (nodeViewWrapper) {
+                node = nodeViewWrapper.firstChild as HTMLElement
+              }
 
-            if (node) {
-              return node.getBoundingClientRect()
+              if (node) {
+                return node.getBoundingClientRect()
+              }
             }
           }