Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use exp/ttl in remember_me plug #649

Merged
merged 3 commits into from
May 17, 2020
Merged

Conversation

Hanspagh
Copy link
Contributor

As described in #645 the current remember_me plug will use the default max_age or it can be overridden in the config. This pr will make the remember_me plug use the exp of the token if it's available as a default.
closes #645

@Hanspagh Hanspagh requested a review from a team as a code owner March 30, 2020 15:33
@Hanspagh
Copy link
Contributor Author

@ueberauth/developers bump

@Hanspagh
Copy link
Contributor Author

I would love some feedback on this @ueberauth/developers

Copy link
Member

@doomspork doomspork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @Hanspagh! Not sure how I messed this 👍

@doomspork doomspork merged commit 694e546 into master May 17, 2020
@doomspork doomspork deleted the fix-remember-me-using-default branch May 17, 2020 13:27
@Hanspagh
Copy link
Contributor Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remember_me ignores token's TTL
2 participants