clean-ups & picosim hardware breakpoint support #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guard FAST_BLOCK by !EXCLUDE_Z80. Remove unneeded checks from simdefs.h (already guarded in sim.h)
So we can test performance impact.
sneakywumpus
changed the title
Also check for '\0' for 'b' and 'bh'. Don't mix f* stdio calls with non-f*.
|
The see what you are missing commands were there for those not familiar with the system. One could remove them completely, but others will not get aware anymore that there are more compile time options. |
|
Ok, I'll leave it as it is. Does my implementation of the hardware breakpoint do what you would expect? I've zero experience with real hardware ICE... If yes, I would add it to the rest of the simulators. |
|
Yes, works well and is like the implementation in a real hardware ICE from what I can remember. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guard FAST_BLOCK by !EXCLUDE_Z80.
Remove unneeded checks from simdefs.h (already guarded in sim.h).
simice: clean-up optional features messages.
Add hardware breakpoint support to picosim, so we can test performance impact.
Or we could switch from the "See what you are missing" paradigm and remove the not enabled commands entirely from the ICE. Thoughts?