Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(templates): added portalElement in floating-toolbar component. #3288

Merged

Conversation

zhyd1997
Copy link
Contributor

@zhyd1997 zhyd1997 commented Jun 15, 2024

Copy link

changeset-bot bot commented Jun 15, 2024

⚠️ No Changeset found

Latest commit: 16297bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jun 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 10:27am

@zhyd1997
Copy link
Contributor Author

zhyd1997 commented Jun 15, 2024

Example usage:

<FloatingToolbar portalElement={editorContainerRef?.current ?? undefined}>
  <FloatingToolbarButtons />
</FloatingToolbar>

@zhyd1997 zhyd1997 changed the title fix(templates): support portalElement in floating-toolbar to fix the toolbar button is no tooltip and not clickable issue. fix(templates): support portalElement in floating-toolbar to fix the toolbar button has no tooltip and is not clickable issue. Jun 15, 2024
@zhyd1997 zhyd1997 changed the title fix(templates): support portalElement in floating-toolbar to fix the toolbar button has no tooltip and is not clickable issue. fix(templates): support portalElement in floating-toolbar to fix the toolbar button has no tooltip and is not clickable issue. Jun 15, 2024
@zhyd1997 zhyd1997 changed the title fix(templates): support portalElement in floating-toolbar to fix the toolbar button has no tooltip and is not clickable issue. fix(templates): support portalElement in floating-toolbar to fix the toolbar button has no tooltip and is not clickable in **dialog** issue. Jun 15, 2024
@zbeyens
Copy link
Member

zbeyens commented Jun 15, 2024

Following shadcn pattern, we don't maintain/extend props since they're owned by the consumer. That means you should add this in your app. Thanks for reporting the bug though, if we have such example, we could use your fix.

@zbeyens zbeyens closed this Jun 15, 2024
@zhyd1997
Copy link
Contributor Author

Hi @zbeyens

But it is hard to debug if the editor is in a dialog.

The devs will take a long time to figure out why the floating buttons have no tooltips and are not clickable.

@zbeyens zbeyens reopened this Jun 15, 2024
@zbeyens
Copy link
Member

zbeyens commented Jun 15, 2024

Could you update the changelog?

@zhyd1997
Copy link
Contributor Author

Sure, but I am on vacation in these 2 days, will update it asap, thanks 🙏

…toolbar button is no tooltip and not clickable issue.
@zhyd1997 zhyd1997 changed the title fix(templates): support portalElement in floating-toolbar to fix the toolbar button has no tooltip and is not clickable in **dialog** issue. fix(templates): added portalElement in floating-toolbar component. Jun 17, 2024
@zhyd1997 zhyd1997 force-pushed the fix/floating-toolbar-in-dialog-1718432542507 branch from e93b8da to 0265f45 Compare June 17, 2024 10:08
@zhyd1997
Copy link
Contributor Author

Hi @zbeyens

Updated changelog done.

@zbeyens zbeyens merged commit a1942ba into udecode:main Jun 17, 2024
3 of 4 checks passed
@zhyd1997 zhyd1997 deleted the fix/floating-toolbar-in-dialog-1718432542507 branch June 17, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants