-
-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(templates): added portalElement
in floating-toolbar
component.
#3288
fix(templates): added portalElement
in floating-toolbar
component.
#3288
Conversation
zhyd1997
commented
Jun 15, 2024
•
edited
Loading
edited
- added changesets
- updated components changelog
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Example usage: <FloatingToolbar portalElement={editorContainerRef?.current ?? undefined}>
<FloatingToolbarButtons />
</FloatingToolbar> |
portalElement
in floating-toolbar
to fix the toolbar button has no tooltip and is not clickable issue.
portalElement
in floating-toolbar
to fix the toolbar button has no tooltip and is not clickable issue.portalElement
in floating-toolbar
to fix the toolbar button has no tooltip and is not clickable in **dialog** issue.
Following shadcn pattern, we don't maintain/extend props since they're owned by the consumer. That means you should add this in your app. Thanks for reporting the bug though, if we have such example, we could use your fix. |
Hi @zbeyens But it is hard to debug if the editor is in a dialog. The devs will take a long time to figure out why the floating buttons have no tooltips and are not clickable. |
Could you update the changelog? |
Sure, but I am on vacation in these 2 days, will update it asap, thanks 🙏 |
…toolbar button is no tooltip and not clickable issue.
portalElement
in floating-toolbar
to fix the toolbar button has no tooltip and is not clickable in **dialog** issue.portalElement
in floating-toolbar
component.
e93b8da
to
0265f45
Compare
Hi @zbeyens Updated changelog done. |