Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Column plugin #3118

Merged
merged 28 commits into from
Apr 20, 2024
Merged

Column plugin #3118

merged 28 commits into from
Apr 20, 2024

Conversation

felixfeng33
Copy link
Collaborator

image Columns Plugin

@felixfeng33 felixfeng33 requested a review from zbeyens April 12, 2024 03:36
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: fac0fed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@udecode/plate-layout Minor
@udecode/plate-serializer-md Minor
@udecode/plate-indent-list Minor
@udecode/plate-toggle Minor
@udecode/plate-emoji Minor
@udecode/plate-table Minor
@udecode/plate Minor
@udecode/plate-serializer-docx Minor
@udecode/plate-serializer-csv Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 20, 2024 11:06am

zbeyens
zbeyens reviewed Apr 16, 2024
View reviewed changes
packages/column/src/column-store.ts Outdated Show resolved Hide resolved
packages/column/package.json Outdated Show resolved Hide resolved
@zbeyens zbeyens changed the title Feat/layout Column plugin Apr 16, 2024
zbeyens
zbeyens reviewed Apr 17, 2024
View reviewed changes
apps/www/src/app/page.tsx Outdated Show resolved Hide resolved
zbeyens
zbeyens requested changes Apr 17, 2024
View reviewed changes
Copy link
Member

@zbeyens zbeyens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Made a few suggestions. You could run yarn brl to generate the index files

packages/layout/package.json Outdated Show resolved Hide resolved
packages/layout/package.json Outdated Show resolved Hide resolved
packages/layout/src/transforms/moveMiddleColumn.ts Outdated Show resolved Hide resolved
packages/layout/src/withColumn.ts Outdated Show resolved Hide resolved
packages/layout/src/withColumn.ts Outdated Show resolved Hide resolved
zbeyens added 2 commits April 17, 2024 14:03
@felixfeng33 felixfeng33 requested a review from zbeyens April 20, 2024 10:49
@zbeyens zbeyens enabled auto-merge April 20, 2024 10:50
@zbeyens zbeyens merged commit 3314038 into main Apr 20, 2024
6 checks passed
@zbeyens zbeyens deleted the feat/layout branch April 20, 2024 11:06
@github-actions github-actions bot mentioned this pull request Apr 20, 2024
Merged
@zbeyens zbeyens mentioned this pull request May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbeyens zbeyens zbeyens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixfeng33 @12joan @zbeyens