Fix link hotkey prevent default (#2005)

* Fix link hotkey prevent default * Create cool-grapes-jam.md
udecode · Nov 21, 2022 · eb6c51e · eb6c51e · vercel · Nov 21, 2022
1 parent 383b03e
commit eb6c51e
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 9 deletions.
diff --git a/.changeset/cool-grapes-jam.md b/.changeset/cool-grapes-jam.md
@@ -0,0 +1,5 @@
+---
+"@udecode/plate-link": patch
+---
+
+Fix link hotkey prevent default
diff --git a/packages/nodes/link/src/components/FloatingLink/useFloatingLinkEdit.ts b/packages/nodes/link/src/components/FloatingLink/useFloatingLinkEdit.ts
@@ -87,10 +87,11 @@ export const useFloatingLinkEdit = ({
   useHotkeys(
     triggerFloatingLinkHotkeys!,
     (e) => {
-      e.preventDefault();
-
-      if (floatingLinkSelectors.mode() === 'edit') {
-        triggerFloatingLinkEdit(editor);
+      if (
+        floatingLinkSelectors.mode() === 'edit' &&
+        triggerFloatingLinkEdit(editor)
+      ) {
+        e.preventDefault();
       }
     },
     {

diff --git a/packages/nodes/link/src/components/FloatingLink/useFloatingLinkInsert.ts b/packages/nodes/link/src/components/FloatingLink/useFloatingLinkInsert.ts
@@ -38,11 +38,9 @@ export const useFloatingLinkInsert = ({
   useHotkeys(
     triggerFloatingLinkHotkeys!,
     (e) => {
-      e.preventDefault();
-
-      triggerFloatingLinkInsert(editor, {
-        focused,
-      });
+      if (triggerFloatingLinkInsert(editor, { focused })) {
+        e.preventDefault();
+      }
     },
     {
       enableOnContentEditable: true,

diff --git a/packages/nodes/link/src/utils/triggerFloatingLinkEdit.ts b/packages/nodes/link/src/utils/triggerFloatingLinkEdit.ts
@@ -32,4 +32,6 @@ export const triggerFloatingLinkEdit = <V extends Value>(
   floatingLinkActions.text(text);
 
   floatingLinkActions.isEditing(true);
+
+  return true;
 };
diff --git a/packages/nodes/link/src/utils/triggerFloatingLinkInsert.ts b/packages/nodes/link/src/utils/triggerFloatingLinkInsert.ts
@@ -42,4 +42,6 @@ export const triggerFloatingLinkInsert = <V extends Value>(
 
   floatingLinkActions.text(getEditorString(editor, editor.selection));
   floatingLinkActions.show('insert', editor.id);
+
+  return true;
 };