Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: breadcrumb as a function, merge with child breadcrumbs properly #45

Merged
merged 3 commits into from
Sep 7, 2020

Conversation

udayvunnam
Copy link
Owner

@udayvunnam udayvunnam commented Sep 7, 2020

PR Checklist

Please check if your PR fulfils the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Provide ability to specify breadcrumb as a function, merge with child breadcrumbs properly

Issue Number: fixes #44, provides - #43

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@udayvunnam udayvunnam merged commit fee7608 into master Sep 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the breadcrumb-as-function branch September 7, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Child breadcrumb with empty path is ignored and replaces parent
1 participant