fix: empty paths #180
Merged
fix: empty paths #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I'm unable to see why the |
udayvunnam
reviewed
Jan 1, 2024
udayvunnam
approved these changes
Jan 1, 2024
|
cskiwi thanks for the PR. will be released with a patch version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about
#177 resolved an issue for empty paths, but this introduced problems with other users (#178, #179)
This is a different approach on checking if the value is not null, but also includes checking for undefined, and empty strings, ...
This should cover all cases from what I could see/test
PR Checklist
Please check if your PR fulfils the following requirements: