refactor(service): Use type predicate in rxjs filter #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udayvunnam
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
Thanks, @LeonFretter. This is a good way to avoid multiple checks on js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about
This uses a type predicate inside the rxjs filter, in the
detectRouteChangesof the service.That makes typescript aware of the event's type, so that subsequently the type doesn't have to be checked again.
(I've checked the boxes below, as it's only a refactor, not a fix/feature.
PR Checklist
Please check if your PR fulfils the following requirements: