Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: angular and nx upgrade to 13 #102

Merged
merged 7 commits into from
Dec 11, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ aliases:
- &defaults
working_directory: ~/repo
docker:
- image: circleci/node:12-browsers
- image: cimg/node:16.13.0-browsers
- &set_env
name: Setup Environment Variables
command: |
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
!.vscode/extensions.json

# misc
/.angular/cache
/.sass-cache
/connect.lock
/coverage
Expand Down
7 changes: 7 additions & 0 deletions .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

branch="$(git rev-parse --abbrev-ref HEAD)"

if [ "$branch" = "main" ]; then
echo "You can't commit directly to main branch"
exit 1
fi

yarn pretty-quick --staged
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ Note: XngBreadcrumb has a peer dependency on `@angular/router`. Include `RouterM
```javascript
{
path: 'dashboard',
loadChildren: './dashboard/dashboard.module#DashboardModule',
loadChildren: () => import('./dashboard/dashboard.module').then((m) => m.DashboardModule)
data: { breadcrumb: 'Home' }
},
{
Expand All @@ -116,7 +116,7 @@ Note: XngBreadcrumb has a peer dependency on `@angular/router`. Include `RouterM
```javascript
{
path: 'dashboard',
loadChildren: './dashboard/dashboard.module#DashboardModule',
loadChildren: () => import('./dashboard/dashboard.module').then((m) => m.DashboardModule)
data: {
breadcrumb: {
label: 'Home',
Expand Down
Loading