Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility - breadcrumb <a> tags cannot be navigated with keyboard #66

Closed
pinkkis opened this issue Dec 9, 2020 · 5 comments · Fixed by #67
Closed

Accessibility - breadcrumb <a> tags cannot be navigated with keyboard #66

pinkkis opened this issue Dec 9, 2020 · 5 comments · Fixed by #67
Labels
bug Something isn't working

Comments

@pinkkis
Copy link

pinkkis commented Dec 9, 2020

🐞 Bug report

Description

Breadcrumbs use a (click) handler for navigation, and do not have a [href] attribute. Pressing tab key to navigate will skip these links. They should either have a href attribute, or then add a tabindex=0 (or customizable).

Edit: Also, if you add tabindex programatically to the <a> tags, you cannot activate the link with a keyboard, as it only has a (click) handler, no keyboard handlers.

🔬 Minimal Reproduction

Any regular use

💻Your Environment

Angular Version:

Angular: 9.1.12
Node: 15.0.1
OS: darwin x64

xng-breadcrumb version
6.3.4

@pinkkis pinkkis added the bug Something isn't working label Dec 9, 2020
@dedrazer
Copy link
Contributor

dedrazer commented Dec 9, 2020

I think this also prevents the cursor from turning into a pointer when it hovers over a breadcrumb

@pinkkis
Copy link
Author

pinkkis commented Dec 9, 2020

Updated to add the edit about not being able to activate links with keyboard

@pinkkis pinkkis changed the title Accessibility - <a> tags without href skipped when tabbing through page Accessibility - breadcrumb <a> tags cannot be navigated with keyboard Dec 9, 2020
pinkkis added a commit to pinkkis/xng-breadcrumb that referenced this issue Dec 9, 2020
@udayvunnam
Copy link
Owner

A recent move from routerLink to (click) caused this issue. routerLink handles a11y implicitly. We had to use (click) to provide support for breadcrumb.routeInterceptor.

Thanks for reporting this issue on a11y. A fix will be rolled out shortly!

@udayvunnam
Copy link
Owner

@pinkkis @dedrazer This issue is fixed and released with version 6.5.0 🎉. Thanks for raising the issue.

@pinkkis
Copy link
Author

pinkkis commented Dec 9, 2020

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants