Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package "xng-breadcrumb" has an incompatible peer dependency to "@angular/platform-browser-dynamic" #118

Closed
fgoulet opened this issue Jan 12, 2022 · 4 comments · Fixed by #123
Assignees
Labels
bug Something isn't working

Comments

@fgoulet
Copy link

fgoulet commented Jan 12, 2022

🐞 Bug report

Description

When I try to update my project from angular 13.1.0 to 13.1.1, I got this error:

Package "xng-breadcrumb" has an incompatible peer dependency to "@angular/platform-browser-dynamic" (requires "13.1.0" (extended), would install "13.1.1")

Would it be possible to update the peer dependencies of xng-breadcrumb ?

Thanks !

Angular Version:

13.1.1

@fgoulet fgoulet added the bug Something isn't working label Jan 12, 2022
@github-actions
Copy link

Hello 👋 @fgoulet
Thank you for raising an issue. We will investigate into the issue and get back to you as soon as possible. Please make sure you have given us as much context as possible.
Feel free to raise a PR if you can fix the issue. Check the local development guide

@marvin-belonio
Copy link

the dependency to angular should probably not be fixed to 13.1.0 but open to angular 13 so "^13.1.0"

marvin-belonio added a commit to marvin-belonio/xng-breadcrumb that referenced this issue Jan 31, 2022
this solves udayvunnam#118 in a more conservative way
@udayvunnam
Copy link
Owner

Whatever we specify in package.json will not end up in the final library when published.

But keeping ^ so it allows patch and minor versions is good practice. I will make this change

@udayvunnam
Copy link
Owner

udayvunnam commented Feb 1, 2022

@marvin-belonio and @fgoulet thanks for raising this issue, it's been fixed in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants