feat: better comments and code seperation

udayvunnam · Oct 30, 2019 · 6257035 · 6257035
1 parent 58c4729
commit 6257035
Show file tree

Hide file tree

Showing 5 changed files with 139 additions and 114 deletions.
diff --git a/projects/xng-breadcrumb-app/src/app/core/navbar/navbar.component.html b/projects/xng-breadcrumb-app/src/app/core/navbar/navbar.component.html
@@ -11,7 +11,7 @@
       <mat-icon aria-label="light theme" *ngIf="theme === 'dark'">wb_incandescent</mat-icon>
     </button>
 
-    <a mat-icon-button href="https://twitter.com/codeasync" target="_blank" matTooltip="Twitter">
+    <a mat-icon-button href="https://twitter.com/udayvunnam_" target="_blank" matTooltip="Twitter">
       <span class="mat-button-wrapper">
         <img alt="Twitter" class="social-logo" src="../../../assets/img/twitter.svg" />
       </span>

diff --git a/projects/xng-breadcrumb/src/lib/breadcrumb.component.html b/projects/xng-breadcrumb/src/lib/breadcrumb.component.html
@@ -2,7 +2,7 @@
   <ol class="breadcrumb">
     <ng-container *ngFor="let breadcrumb of breadcrumbs$ | async; last as isLast">
       <li class="breadcrumb-item" [ngClass]="{ active: isLast }" [attr.aria-current]="isLast ? 'page' : null" *ngIf="!breadcrumb.skip">
-        <a *ngIf="!isLast; else lastRoute" [routerLink]="[breadcrumb.route]" routerLinkActive="active">
+        <a *ngIf="!isLast; else lastRoute" [routerLink]="[breadcrumb.routeLink]" routerLinkActive="active">
           {{ breadcrumb.label }}
         </a>
         <ng-template #lastRoute>

diff --git a/projects/xng-breadcrumb/src/lib/breadcrumb.component.ts b/projects/xng-breadcrumb/src/lib/breadcrumb.component.ts
@@ -1,8 +1,6 @@
-import { OnInit, Component, Input } from '@angular/core';
-import { BreadcrumbService } from './breadcrumb.service';
+import { Component, Input, OnInit } from '@angular/core';
 import { Observable } from 'rxjs';
-import { filter } from 'rxjs/operators';
-import { Breadcrumb } from './breadcrumb';
+import { BreadcrumbService } from './breadcrumb.service';
 
 @Component({
   selector: 'xng-breadcrumb',

diff --git a/projects/xng-breadcrumb/src/lib/breadcrumb.module.ts b/projects/xng-breadcrumb/src/lib/breadcrumb.module.ts
@@ -1,9 +1,7 @@
-import { NgModule } from '@angular/core';
 import { CommonModule } from '@angular/common';
+import { NgModule } from '@angular/core';
 import { RouterModule } from '@angular/router';
 import { BreadcrumbComponent } from './breadcrumb.component';
-import { ModuleWithProviders } from '@angular/compiler/src/core';
-import { BreadcrumbService } from './breadcrumb.service';
 
 @NgModule({
   declarations: [BreadcrumbComponent],