This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
Memory management fix | Adding max number of active threads #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronwp
reviewed
Dec 23, 2016
| }; | ||
| }; | ||
|
|
||
| var QRCodeManager = function(element) { | ||
| this.numActiveThreads = 0; | ||
| this.maxThreads = 4; |
There was a problem hiding this comment.
Just an arbitrary number - good question hehe
A better approach could be:
this.maxThreads = window.navigator.hardwareConcurrency || 4;https://developer.mozilla.org/en-US/docs/Web/API/NavigatorConcurrentHardware/hardwareConcurrency
I'll update the PR tonight
cameronwp
reviewed
Dec 23, 2016
| qrCodeManager.showDialog(url); | ||
| } | ||
| }); | ||
| if (qrCodeManager.numActiveThreads < qrCodeManager.maxThreads) { |
There was a problem hiding this comment.
what happens if numActiveThreads is over maxThreads? does the frame get dropped?
There was a problem hiding this comment.
The consequence is: The worker won't be called.
On my i5 it takes about 10ms for the worker to respond back, at the worst case scenario we'll have a "10ms lag", ** 2.5ms** on the best case, not noticeable.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey @cameronwp
I had to bump node-sass version to get the
solutionbranch to work, not sure why tho.