-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add docker layer caching and nb_conda_kernels
#13
Conversation
add ghcr and mamba to our container setup
enable docker layer caching to speed up builds
remove manual kernel declarations and use `nb_conda_kernels`
Wesley, I'm marking you as a reviewer in case you have any comments. Besides a quick check on our work, we'd be curious to hear if you think any of these changes might have unintended side effects or if there are consequences we might not have considered. But also feel free to ignore this PR, especially if you're out for a (well deserved) holiday break now! |
Not sure why the build failed. The logs seem to indicate that it's some sort of permission issue. I'm guessing it's something to due with the fact that this PR originates from a fork. |
@aryarm Your changes look good and I looked into this issue. I'm not sure if it's possible for a forked branch from another organization (e.g. In any case, once you merge the pull request, the action should clear if the docker build is successful. |
ok, thanks for the quick response! merging now |
remove rstudio from wi24 environment
This PR makes two changes:
This allows us to cache portions of our build process, so that re-builds happen only for the portions of our Dockerfile that need to be rerun, potentially saving us substantial amounts of time.
For example, let's say that we make a commit in which the only change is to one of our conda environment files. And let's say that the environment file in question gets
COPY
-ed into the container on line 10 of the Dockerfile.Docker layer caching means that when the container image gets rebuilt for this commit, Docker will automatically restart the build process on line 10 instead of starting from the beginning of the Dockerfile.
nb_conda_kernels
in our Dockerfile and resolves usenb_conda_kernels
instead of installing each kernel manually #10