Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Details: add clickListener to Summary field #9

Open
Herm71 opened this issue Aug 1, 2023 · 1 comment · Fixed by #17
Open

Details: add clickListener to Summary field #9

Herm71 opened this issue Aug 1, 2023 · 1 comment · Fixed by #17
Assignees
Labels
bug Something isn't working

Comments

@Herm71
Copy link
Member

Herm71 commented Aug 1, 2023

After adding the details block, the initial click into the field opens/closes the block prior to being able to edit the field. The edit.js file currently employs a "listener" on the space bar. I believe we need one for Click, too.

Current listener as example:

const keyUpListener = ( e ) => { if ( e.keyCode === SPACE ) { e.preventDefault(); } };

@Herm71 Herm71 added the bug Something isn't working label Aug 1, 2023
@Herm71 Herm71 self-assigned this Aug 1, 2023
@Herm71 Herm71 changed the title Wonky initial click into summary field Add clickListener to Summary field Aug 1, 2023
@Herm71 Herm71 changed the title Add clickListener to Summary field Details: add clickListener to Summary field Aug 1, 2023
@Herm71 Herm71 closed this as completed in #17 Aug 4, 2023
Herm71 added a commit that referenced this issue Aug 4, 2023
fix: 🐛 Details: add clickListener to Summary field  Fixes #9
@Herm71 Herm71 reopened this Aug 4, 2023
@Herm71
Copy link
Member Author

Herm71 commented Aug 4, 2023

Re-opening issue. "Fix" didn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant