Skip to content

Commit

Permalink
Merge pull request #23 from uclixnjupyternbaccessibility/issue-3217
Browse files Browse the repository at this point in the history
Fixed Issue jupyter#3217 by adding main and navigation roles
  • Loading branch information
joshuazeltser authored Jun 27, 2019
2 parents 7f7388f + fba8543 commit 25a1ca6
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ __pycache__
.coverage
.pytest_cache
src

*.iml
*.swp
*.map
.idea/
Expand Down
2 changes: 2 additions & 0 deletions notebook/templates/notebook.html
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@

{% endblock headercontainer %}

<div role="navigation">
{% block header %}
<div id="menubar-container" class="container">
<div id="menubar">
Expand Down Expand Up @@ -330,6 +331,7 @@
</div>
</div>
</div>
</div>

<div id="maintoolbar" class="navbar">
<div class="toolbar-inner navbar-inner navbar-nobg">
Expand Down
10 changes: 5 additions & 5 deletions notebook/templates/page.html
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@
</div>
</noscript>

<div id="header">
<div id="header" role="navigation" aria-label="Top Menu">
<div id="header-container" class="container">
<div id="ipython_notebook" class="nav navbar-brand"><a href="{{default_url}}
{%- if logged_in and token -%}?token={{token}}{%- endif -%}" title='{% trans %}dashboard{% endtrans %}'>
Expand All @@ -147,17 +147,17 @@
{% endblock %}

{% endblock header_buttons %}

</div>
<div class="header-bar"></div>

{% block header %}
{% endblock %}
</div>
</div>

<div id="site">
{% block site %}
{% endblock %}
{% block site %}
{% endblock %}
</div>

{% block after_site %}
Expand Down
5 changes: 3 additions & 2 deletions notebook/templates/tree.html
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{% extends "page.html" %}

{% block title %}{{page_title}}{% endblock %}


Expand Down Expand Up @@ -27,7 +26,8 @@
{% block site %}

<div id="ipython-main-app" class="container">
<div id="tab_content" class="tabbable">

<div id="tab_content" class="tabbable" role="main">
<ul id="tabs" class="nav nav-tabs">
<li class="active"><a href="#notebooks" data-toggle="tab" role="tab">{% trans %}Files{% endtrans %}</a></li>
<li><a href="#running" data-toggle="tab" role="tab">{% trans %}Running{% endtrans %}</a></li>
Expand Down Expand Up @@ -224,3 +224,4 @@
<script src="{{ static_url("tree/js/main.min.js") }}" type="text/javascript" charset="utf-8"></script>

{% endblock %}

0 comments on commit 25a1ca6

Please sign in to comment.