Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link embeds are flaky #194

Closed
mattxwang opened this issue Jun 30, 2021 · 0 comments · Fixed by #244
Closed

Link embeds are flaky #194

mattxwang opened this issue Jun 30, 2021 · 0 comments · Fixed by #244
Assignees
@mattxwang

Comments

@mattxwang
Copy link
Member

Just did some testing with our new Next site, and noticed that link embeds are still a flaky. Some notes on the homepage (likely the most important page):

  • on Discord, there's no embed at all
  • on facebook messenger, the image doesn't work as intended
  • works on Instagram DM, though the image is the first news item
  • works on FB post, though the image is the first news item

This should be part of a larger issue surrounding one of the post-action items of #178, which is properly filling out SEO - i.e. #116.
@mattxwang mattxwang self-assigned this Aug 10, 2021
@mattxwang mattxwang mentioned this issue Aug 18, 2021
Merged
mattxwang added a commit that referenced this issue Aug 20, 2021
@mattxwang
per-page SEO (meta tags, opengraph) via next-seo (#244)
354a8a4 
This PR implements per-page SEO tags via [`next-seo`](https://github.com/garmeeh/next-seo). Under-the-hood, the package handles basic meta tags, and OpenGraph URLs; according to the documentation, Twitter now also parses OG data, and thus doesn't generate twitter-specific metadata.

I then manually write and apply copy for each page: the home page, about, committees, events, sponsors, and tech gala. We'll have to backport this to other new pages, like the ones introduced in #238 and #235. I chose not to add any default templating or abstract this to a component, since I think the copy differs enough where boilerplate doesn't help us too much.

For reviewers - it would be great if you could test this on a variety of social media platforms (Facebook, Twitter, Discord, Instagram. etc.). I've done Discord testing in the #test3 moderator channel of the server, as well as DMing myself on FB messenger.

Closes #116, (hopefully) closes #194.
mattxwang added a commit that referenced this issue Aug 20, 2021
@mattxwang
per-page SEO (meta tags, opengraph) via next-seo (#244)
625a5fb 
This PR implements per-page SEO tags via [`next-seo`](https://github.com/garmeeh/next-seo). Under-the-hood, the package handles basic meta tags, and OpenGraph URLs; according to the documentation, Twitter now also parses OG data, and thus doesn't generate twitter-specific metadata.

I then manually write and apply copy for each page: the home page, about, committees, events, sponsors, and tech gala. We'll have to backport this to other new pages, like the ones introduced in #238 and #235. I chose not to add any default templating or abstract this to a component, since I think the copy differs enough where boilerplate doesn't help us too much.

For reviewers - it would be great if you could test this on a variety of social media platforms (Facebook, Twitter, Discord, Instagram. etc.). I've done Discord testing in the #test3 moderator channel of the server, as well as DMing myself on FB messenger.

Closes #116, (hopefully) closes #194.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattxwang mattxwang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

per-page SEO (meta tags, opengraph) via next-seo uclaacm/website
1 participant
@mattxwang