Add an API for submitting sketches to a class #72 #145
Conversation
There was a problem hiding this comment.
Hey Marianne, overall this looks pretty good. There are just a couple of small typos. In the future, if you use https://golangci-lint.run/usage/install/#local-installation or something similar, these types of errors can be caught earlier. Thank you for your work! :)
Edit: One more thing, it would be good to add a small description to your PR in the future. It really helps contextualize the PR.
handler/class.go
Outdated
| if err := httpext.RequestBodyTo(c.Request(), &req); err != nil { | ||
| return c.String(http.StatusInternalServerError, err.Error()) | ||
| } | ||
| if submissionPID.uid == "" { |
There was a problem hiding this comment.
This should be req.submissionPID
handler/class.go
Outdated
| if submissionPID.uid == "" { | ||
| return c.String(http.StatusBadRequest, "submission PID is required") | ||
| } | ||
| if assignmentPID.uid == "" { |
There was a problem hiding this comment.
Same here, req.assignmentPID
| if req.cid == "" { | ||
| return c.String(http.StatusBadRequest, "cid is required") | ||
| } | ||
| } |
There was a problem hiding this comment.
For now, if you just add return nil at the end of the function, it should work as expected
taking in two PIDs, a CID, and a UID. Fixed typos and had it return nothing.
There was a problem hiding this comment.
Hey Marianne, there are a couple more compile errors. I understand that it's not very simple to test a new API like this, but here are some basic steps you can take to "soft verify" any changes:
- building and running the server should happen without any errors
go fmtshould run without any errors- tests on GitHub should not fail
This may not catch all the errors, but some obvious ones like typos, etc can be found this way.
| if err := httpext.RequestBodyTo(c.Request(), &req); err != nil { | ||
| return c.String(http.StatusInternalServerError, err.Error()) | ||
| } | ||
| if req.submissionPID.uid == "" { |
There was a problem hiding this comment.
| if req.submissionPID.uid == "" { | |
| if req.submissionPID == "" { |
| if req.submissionPID.uid == "" { | ||
| return c.String(http.StatusBadRequest, "submission PID is required") | ||
| } | ||
| if req.assignmentPID.uid == "" { |
There was a problem hiding this comment.
| if req.assignmentPID.uid == "" { | |
| if req.assignmentPID == "" { |
No description provided.