View-Only: Fixes Redux State Corruption #245
Conversation
The bug: Open a sketch in view-only mode. Go to the sketches page and try to download your most recently viewed sketch. The sketch title and extension are as expected, but the code is the code from the view-only sketch. This fixes the bug by saving the original code for the most recently viewed program, and restoring it before the component unmounts.
this is also a bandaid fix
|
Just added a check to make sure the user is logged in when we do the saving; if not, then it didn't work. |
Awesome, sounds good. If we can't find one super quickly, I don't mind merging this, then merging view only, then the go backend, and then reworking how mostRecentProgram and some of our Redux actions/state holders work. |
There was a problem hiding this comment.
Looking over things a bit more, this is definitely something that needs to be handled in a separate PR. As it stands, view-only will be refactoring a great deal of our existing code in addition to adding a brand new feature. Though it may be a bit rash, I think that for the time being we will have to live with this quick fix and resolve it later down the line since it likely requires a host of other refactors.
|
Sounds good, thanks for the comment Leo. merging! |
PR Fix implemented by @jamieliu386:
The bug:
This happens because the Redux state is corrupted with
mostRecentProgram; this is a temporary bandaid that properly deals with the Redux state, but doesn't solve the core problem.This PR fixes the bug by saving the original code for the most recently viewed program when View-Only is entered, and then restores it before the component unmounts.
@jamieliu386 and/or @krashanoff, I'd like to see if there's a quicker bandaid style fix for this - refactoring
mostRecentProgramand our Redux user manager (i.e. clearing out the state when the user logs out, storing the right things in cookies, etc.) is likely out of scope for the View Only PR, but I'm concerned about the dependence on the lifecycle hook.