Add gsf module #303
Add gsf module #303
Conversation
lispandfound
requested review from
sungeunbae,
claudio525 and
AndrewRidden-Harper
|
I have also added a new coordinate transformation module, and all the GSF related code from the type5 branch of Pre-processing. The coordinate transformation module is required for the GSF meshgrid generator. @claudio525 I know you approved the trivial parsing code, but it now includes quite a bit more. I will also add a description of the GSF file format to the wiki because I don't think it's documented anywhere. |
qcore/coordinates.py
Outdated
| nztm_coords = np.array( | ||
| _WGS2NZTM.transform(wgs_depth_coordinates[:, 0], wgs_depth_coordinates[:, 1]), | ||
| ).T | ||
| return np.append(nztm_coords, wgs_depth_coordinates[:, 2].reshape((-1, 1)), axis=-1) |
There was a problem hiding this comment.
This can be simplified to just
nztm_coords = np.array( _WGS2NZTM.transform(wgs_depth_coordinates[:, 0], wgs_depth_coordinates[:, 1], wgs_depth_coordinates[:, 2])).T
There was a problem hiding this comment.
These comments would be nice to address?
|
@sungeunbae @joelridden I have addressed these concerns. I'll leave the unhappy parallel array gsf writing function for now but include a fault class into qcore that I can use in NSHMDB, Pre-Processing and any places later on where the database or type-5 code gets incorporated. That will be a separated pull request. |
qcore/coordinates.py
Outdated
| nztm_coords = np.array( | ||
| _WGS2NZTM.transform(wgs_depth_coordinates[:, 0], wgs_depth_coordinates[:, 1]), | ||
| ).T | ||
| return np.append(nztm_coords, wgs_depth_coordinates[:, 2].reshape((-1, 1)), axis=-1) |
There was a problem hiding this comment.
These comments would be nice to address?
lispandfound
requested review from
sungeunbae,
AndrewRidden-Harper,
joelridden and
claudio525
lispandfound
dismissed stale reviews from AndrewRidden-Harper and sungeunbae
via
0899004
lispandfound
requested review from
joelridden,
sungeunbae and
AndrewRidden-Harper
@claudio525 Mentioned that the parsing code in ucgmsim/visualization#91 may have broader application and so should be included in qcore. I agree, so this pull request contains the GSF parsing code.