-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Typer CLI Interface #2
Conversation
Good to see a PR being used as the communication means. Quite enlightening to see new Python packages/technique in action. I understand this is still a work in progress and its primary purpose is to share the info. However, if you add a docstring to each function, it will be fantastic. |
@sungeunbae Just to put what we discussed today in writing for the future. No. It does not format the code. I think this is for the best. Instead it simply checks that the code is black complaint (like what the Jenkins build server currently does). The advantages are two-fold:
name: Lint
on: [push, pull_request]
jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: psf/black@stable The The checks are made at exactly the same time the Jenkins server does, i.e. when you create a pull request as prerequisite for merging into the main branch. For our purpose this is a drop-in replacement for the Jenkins workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from claudio's comments I approve.
Outside of this PR, but could be good at some stage to have some reading functions for those to be able to access fault / rupture information from the DB without having to understand how to do SQL etc.
Cool - we have no immediate plan to add extra automated tests other than black. I'm supportive of more integration into github eco-system. |
This PR is here for a few reasons: