Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a filter to the Module Library page. #2056

Conversation

FrenjaminBanklin
Copy link
Contributor

Resolves #2000.

Module library page now hydrates to enable live filtration.

Module/collection filter functions were moved into their own file to be shared easily between components.

Added a function to the collection backend model to enable looking up all public collections, whenever that becomes necessary.

…on. Module/collection filter functions were moved into their own file to be shared easily between components. Added a function to the collection backend model to enable looking up all public collections, whenever that becomes necessary.
@RachelDau
Copy link
Contributor

Looks like the filter works well when I tested the branch. I noticed when you click into the filter search on chrome a popup of '0' comes up and goes away when you type a character, but I am not sure if it is related to this PR. It only happens with chrome on my computer.
image
Screen Shot 2023-01-19 at 8 12 38 AM

@RachelDau
Copy link
Contributor

I think this is some sort of suggested auto fill thing on chrome and not related to the changes, but I am not sure how it works so I figured I would bring it up.

@FrenjaminBanklin
Copy link
Contributor Author

The suggested text is definitely not an Obojobo thing, so I don't think it's a problem as far as this PR is concerned.

@RachelDau RachelDau self-requested a review January 25, 2023 18:43
RachelDau
RachelDau previously approved these changes Jan 25, 2023
@Viggie1
Copy link

Viggie1 commented Feb 6, 2023

Functionality of filter works great, LGTM. If there is any desire to "pretty" up the page, it may be a good idea to add a "No Module Found" message if someone were to type in the name of a module they thought they added but didn't. Currently it just shows a blank section (as shown below). This is all preference though, all in all the filtering does its job.
image

Copy link
Contributor

@RachelDau RachelDau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Locally it is all working on all three browsers for me.

@FrenjaminBanklin FrenjaminBanklin merged commit 975203b into ucfopen:dev/30-howlite Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants