Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS import optimizations #1563

Conversation

clpetersonucf
Copy link
Member

@clpetersonucf clpetersonucf commented Jan 31, 2024

  • Adds a new optimization section to the dev and prod webpack configs. Common JS dependencies are bundled into a new commons.js file.
  • Adds commons.js to the package.json manifest for the materia-widget-dependencies package.
  • Updates the JS FuelPHP config to remove hard-coded react development dependencies and replaces them with the commons.js file.

Copy link
Contributor

@FrenjaminBanklin FrenjaminBanklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't stumbled across anything breaking after checking functionality throughout the app. Better load times will be nice.

@clpetersonucf clpetersonucf merged commit 39dbf74 into ucfopen:dev/10.1.0 Feb 1, 2024
2 checks passed
@clpetersonucf clpetersonucf deleted the issue/1562-js-import-optimizations branch February 1, 2024 21:46
@clpetersonucf clpetersonucf mentioned this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants