-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AXI Memory Over TL Serial Link #121
Conversation
Niceeeee. |
While this is strictly better than those examples... there is one caveat... passing an extra clock/reset wire from the SoC over to this harness module. This is needed for FireSim to work (since all clocks need to come from the SoC... unless you want the clock bridge to be wired weirdly to both the harness and the SoC - though both reside in the "target" domain) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems pretty reasonable to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good except for the reset change at the end.
src/main/scala/SerialAdapter.scala
Outdated
axiClockParams match { | ||
case Some(clkParams) => clkParams.clockFreqMHz * (1000 * 1000) | ||
case None => { | ||
// get freq. from what the master of the serial link specifies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this getting the frequency from what the serial link masters rather than what masters the serial link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yea this comment is off. The serial link masters the FBUS and is slave to the MBUS. The code is still fine though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This setup matches closely with the current Berkeley bringup setup where the AXI memory interface resides over the serial link and is in a different clock domain.
connectHarnessMultiClockAXIRAM
andMultiClockSerialAXIRAM
functions/modules that have AXI memory interface over TL serial linkSerialTLParams
to keep track of AXI clock freq. (used in IO/HarnessBinder to specify clock source and correctly giveSimDRAM
frequency)