Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use root user for the Dockerfile #883

Merged
merged 5 commits into from
May 13, 2021
Merged

Use root user for the Dockerfile #883

merged 5 commits into from
May 13, 2021

Conversation

abejgonzalez
Copy link
Contributor

Related issue:

Type of change: other enhancement

Impact: other

Release Notes
Turns out root user is ideal for GitHub actions work. This PR is testing the current CI infrastructure with it.

@abejgonzalez abejgonzalez self-assigned this May 11, 2021
@abejgonzalez abejgonzalez requested a review from chick May 11, 2021 23:07
@chick
Copy link
Collaborator

chick commented May 12, 2021

@abejgonzalez This looks good for my work on using github actions, I am using this new docker image in my tests, so far so good. I am not sure about the errors occurring here on this PR

@abejgonzalez
Copy link
Contributor Author

@chick Fixed the issues. Can you try this new CI image and re-review this PR?

Copy link
Collaborator

@chick chick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for my latest abilities to test things under github actions.
Looks good to me in general.

@abejgonzalez abejgonzalez merged commit 65fae6b into dev May 13, 2021
@abejgonzalez abejgonzalez deleted the root-dockerfile branch October 7, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants