Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[firechip] Memoize Clock RecordMap creation to fix SuperNode #882

Merged
merged 1 commit into from
May 7, 2021

Conversation

davidbiancolin
Copy link
Contributor

Supernode fails to elaborate using the new harness extensions to clock bridge instantiation. I got a little carried away with stylistic changes (i can undo those), but this fixes that by permitting multiple requests to requestClockRecordMap.

Type of change: bug fix

Impact: rtl change

Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidbiancolin davidbiancolin merged commit 1f28d37 into dev May 7, 2021
@davidbiancolin davidbiancolin deleted the supernode-cb-fix branch May 7, 2021 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants