test whether git.qemu.org rewrite still needed #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #876 (comment) it was requested that we add a note to build-toolchains.sh saying that the url rewrites can be removed. I went a step further and made it self-checking. Once qemu is bumped far enough that none of it's submodules come from git.qemu.org, then the test added in this commit will fail CI during the bump PR and everyone will be reminded to remove the url renaming rules and change module_build back to module_all for qemu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #876
Type of change: other enhancement
Impact: other
Release Notes
In #876 (comment)
it was requested that we add a note to build-toolchains.sh saying that the
url rewrites can be removed. I went a step further and made it self-checking.
Once qemu is bumped far enough that none of it's submodules come from
git.qemu.org, then the test added in this commit will fail CI during the bump PR
and everyone will be reminded to remove the url renaming rules and change
module_build back to module_all for qemu.