Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ScalaTest Chipyard test #875

Merged
merged 2 commits into from
May 4, 2021
Merged

Fix ScalaTest Chipyard test #875

merged 2 commits into from
May 4, 2021

Conversation

abejgonzalez
Copy link
Contributor

Related issue: #860

Type of change: bug fix

Impact: other

Release Notes
Tested with make -C sims/vcs launch-sbt with project chipyard; test.

davidbiancolin
davidbiancolin approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@davidbiancolin davidbiancolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abejgonzalez
Copy link
Contributor Author

Merging since this isn't checked by CI anyways.

@abejgonzalez abejgonzalez merged commit 3fbd1ef into dev May 4, 2021
@abejgonzalez abejgonzalez deleted the milovanovic-master branch May 4, 2021 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbiancolin davidbiancolin davidbiancolin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abejgonzalez @davidbiancolin @milovanovic