-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requirement Scripts Update #874
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bintray has gone down. SBT's website now provides these as install commands.
Ubuntu 20.04 LTS (the most recent LTS release) stopped shipping Python 3.6 in their default repositories. Upping it to Python 3.8 does not seem to have broken the design/elaboration process. I tested re-building Chipyard and all its dependencies using this new version, and everything appears to have remained the same.
Ubuntu does not ship with curl by default any more. If we are to use curl to install SBT's required information, we must ensure it is available for use on Ubuntu.
…ard into KarlJoad-update-to-python3.8
…oad/chipyard into KarlJoad-update-initial-setup-scripts
…to KarlJoad-Combined
…ripts' into KarlJoad-Combined
This was referenced May 3, 2021
Closed
alonamid
approved these changes
May 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closed
This was referenced May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #867 #868
Type of change: other enhancement + bugfix
Impact: other
Release Notes
This combines all setup script-related changes and also bumps the (Ubuntu-based) Docker file used for CI (which runs the Ubuntu script for setup). This will test that at least the Ubuntu changes work and are backwards compatible with 16/18.04.