Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Images Comment in Docs #864

Merged
merged 2 commits into from
Apr 28, 2021
Merged

Docker Images Comment in Docs #864

merged 2 commits into from
Apr 28, 2021

Conversation

alonamid
Copy link
Contributor

Related issue: #857

Type of change: bug fix | new feature | other enhancement

Impact: other

Release Notes

@alonamid alonamid requested a review from abejgonzalez April 21, 2021 22:30
@abejgonzalez
Copy link
Contributor

This is failing the docs check.

@@ -16,7 +16,7 @@ In CentOS-based platforms, we recommend installing the following dependencies:
.. include:: /../scripts/centos-req.sh
:code: bash

In Ubuntu/Debian-based platforms (Ubuntu), we recommend installing the following dependencies:
In Ubuntu/Debian-based platforms (Ubuntu), we recommend installing the following dependencies. These dependancies were written based on Ubuntu 16.04 LTS and 18.04 LTS - If they don't work for you, you can try out the Docker image (:ref:`Pre-built Docker Image`) before manually installing or removing dependancies:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In Ubuntu/Debian-based platforms (Ubuntu), we recommend installing the following dependencies. These dependancies were written based on Ubuntu 16.04 LTS and 18.04 LTS - If they don't work for you, you can try out the Docker image (:ref:`Pre-built Docker Image`) before manually installing or removing dependancies:
In Ubuntu/Debian-based platforms (Ubuntu), we recommend installing the following dependencies. These dependencies were written based on Ubuntu 16.04 LTS and 18.04 LTS - If they don't work for you, you can try out the Docker image (:ref:`Pre-built Docker Image`) before manually installing or removing dependencies:

Copy link
Contributor

@abejgonzalez abejgonzalez Apr 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in separate commit.

Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abejgonzalez
Copy link
Contributor

Documentation passes. Merging.

@abejgonzalez abejgonzalez merged commit 1fd2ccc into dev Apr 28, 2021
@abejgonzalez abejgonzalez deleted the alonamid-patch-2 branch May 3, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants