Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronize JTAG reset to JTAG.TCK. #859

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Synchronize JTAG reset to JTAG.TCK. #859

merged 1 commit into from
Apr 19, 2021

Conversation

jerryz123
Copy link
Contributor

Related issue:

Type of change: bug fix

Impact: rtl change

@jerryz123 jerryz123 requested a review from abejgonzalez April 17, 2021 09:01
abejgonzalez
abejgonzalez approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerryz123 jerryz123 merged commit 22f6fd5 into dev Apr 19, 2021
abejgonzalez
abejgonzalez reviewed Apr 19, 2021
View reviewed changes
Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, is this really needed? If the JTAG is used, the systemjtag.reset is already synchronized in the connectDebugClockHelper to the clockBundle.clock (which isn't the j.jtag.TCK).

@jerryz123
Copy link
Contributor Author

I don't see the systemjtag.reset getting synchronized.
Adding a synchronizer here matches what was done on past chips.

@alonamid alonamid mentioned this pull request Jun 4, 2021
Merged
@jerryz123 jerryz123 deleted the jtag-reset-sync branch June 10, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abejgonzalez abejgonzalez abejgonzalez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerryz123 @abejgonzalez