Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update barstools.rst #845

Merged
merged 7 commits into from
Apr 6, 2021
Merged

Update barstools.rst #845

merged 7 commits into from
Apr 6, 2021

Conversation

mysoreanoop
Copy link
Contributor

Added info about adding our own sram-macros cache

Related issue:

Type of change: other enhancement

Impact: unknown

Release Notes

davidbiancolin and others added 3 commits February 24, 2021 13:05
[FireChip] Update frequency selection related comments
Added info about adding our own sram-macros cache
Copy link
Contributor

@colinschmidt colinschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move this first sentence to the line above the For information writing mdf sentence. And then move the link to the json format to the beginning of the section that sentence links to.

@alonamid alonamid changed the base branch from master to dev April 5, 2021 17:46
@colinschmidt
Copy link
Contributor

We redirected this PR to the dev branch, but it now has conflicts @mysoreanoop can you fix those conflicts. Otherwise we are ready to merge. Thanks

Copy link
Contributor

@colinschmidt colinschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the help!

@colinschmidt colinschmidt merged commit f49af51 into ucb-bar:dev Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants