Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WithMultiRoCCFromBuildRoCC to make heterogeneous accelerator configs easier #809

Merged
merged 1 commit into from
Mar 1, 2021
Merged

Add WithMultiRoCCFromBuildRoCC to make heterogeneous accelerator configs easier #809

merged 1 commit into from
Mar 1, 2021

Conversation

jerryz123
Copy link
Contributor

This fragment basically lets you copy the contents of the BuildRoCC key into a MultiRoCC hart mapping, so you no longer have to define custom WithMultiRoCCX fragments for each accelerator you want to use with MultiRoCC

Type of change: new feature

@jerryz123 jerryz123 requested a review from abejgonzalez March 1, 2021 08:15
abejgonzalez
abejgonzalez approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we want to remove the other approach and re-work the examples?

@jerryz123
Copy link
Contributor Author

Let's leave that stuff in for now.

@jerryz123 jerryz123 merged commit 43a408e into dev Mar 1, 2021
@alonamid alonamid mentioned this pull request Jun 4, 2021
Merged
@jerryz123 jerryz123 deleted the better-multirocc branch November 3, 2021 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abejgonzalez abejgonzalez abejgonzalez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerryz123 @abejgonzalez