Heterogeneous doc patches #796
Conversation
There were two problems here:
1. The docs indicated that this should be a dual-BOOM and
single-Rocket config, but the config actually had two Rocket
cores.
2. Since the doc include string was 'DualBoomAndRocket', it was
accidentally matching against the 'DualBoomAndRocketOneHwacha'
section, which comes first in the file.
So, I created a new 'DualLargeBoomAndSingleRocketConfig' config which
only has one Rocket core, and changed the doc include string to
'DualBoomAndSingleRocket'.
|
The ordering is sequential from bottom up (or right to left), following the behavior of other config fragments. Generates |
|
Great, thanks @jerryz123 ! In that case, looking at this config: class LargeBoomAndHwachaRocketConfig extends Config(
new chipyard.config.WithMultiRoCC ++ // support heterogeneous rocc
new chipyard.config.WithMultiRoCCHwacha(1) ++ // put hwacha on hart-1 (rocket)
new hwacha.DefaultHwachaConfig ++ // set default hwacha config keys
new boom.common.WithNLargeBooms(1) ++ // add 1 boom core
new freechips.rocketchip.subsystem.WithNBigCores(1) ++ // add 1 rocket core
new chipyard.config.AbstractConfig)the rocket core should be hart 0, and the boom core hart 1. That means we should change |
|
Oh yeah, that comment is wrong. That should be |
The docs indicate that this should be a dual-BOOM and single-Rocket config, with the Hwacha attached to the Rocket. However, the 'LargeBoomAndHwachaRocketConfig' config only has a single Rocket core. Added the 'DualLargeBoomAndHwachaRocketConfig' config to accurately reflect what's stated in the docs. Additionally, this fixes hart numbering to place the Hwacha accelerator on the Rocket core rather than on the BOOM core.
tymcauley
force-pushed
the
heterogeneous-doc-patches
branch
from
1d57c44 to
01948f6
Compare
|
Alright, I fixed that issue, and I also added some text at the bottom of that page explaining hart ID ordering in a bit more detail. |
|
Alright, I'm happy with this PR, let me know if you'd like me to change anything. |
Related issue: #786
Type of change: documentation
Impact: documentation
Release Notes
Fix documentation for Heterogeneous SoCs, add documentation on hart ID ordering.