-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rocket, make possible to use published deps #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the motivation to move the verisim/csrc stuff out of testchipip? Or is it different somehow?
My latest commit removes I made a transform based on the blackboxresource transform to attach some resources to the TestHarness. This adds the csrc. Ideally, I would conditionally include Headers are tricky because they should be included with the |
After running a clean build, I realized old build state was masking this problem. verisim/csrc needs to be in the include path until we find a more permanent solution to our problem.
Yeah, that's sort of what I'm thinking |
We had bootrom in project-template initially, but eventually moved it to testchipip. I'd rather we keep it there. |
@zhemao do you think it's OK to put bootrom in testchipip's |
Yeah, we could put it in src/main/resources. |
Now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving per rebar
feedback
SBT
tosbt -DROCKET_USE_MAVEN ++2.12.4
causes build to ignore testchipip and rocket-chip, instead using published dependencies. If you don't overrideSBT
, it uses the submodules as before