chore(deps): update various deps, remove unused code #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avantol13
commented
Sep 6, 2023
| @@ -73,7 +73,6 @@ | |||
| "https://s3.amazonaws.com/dictionary-artifacts/datadictionary/develop/schema.json", | |||
| ) | |||
|
|
|||
| HMAC_ENCRYPTION_KEY = os.environ.get("CDIS_HMAC_ENCRYPTION_KEY", "") | |||
There was a problem hiding this comment.
this isn't used anywhere in the code, I'm not sure why it's here. It's the only place where cryptography was used, so remove this and the library
BinamB
approved these changes
Sep 6, 2023
grugna
added a commit
to chicagopcdc/sheepdog
that referenced
this pull request
Sep 25, 2023
chore(deps): update various deps, remove unused code (uc-cdis#399)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes