Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getServiceVersion: handle service names with dash #652

Merged
merged 3 commits into from
Jul 16, 2021
Merged

getServiceVersion: handle service names with dash #652

merged 3 commits into from
Jul 16, 2021

Conversation

paulineribeyre
Copy link
Contributor

@paulineribeyre paulineribeyre commented Jul 15, 2021 •
edited
Loading

closes #651

Bug Fixes

  • Handle service names with dash in getServiceVersion/runTestsIfServiceVersion

themarcelor
themarcelor approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@themarcelor themarcelor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 I'm not 100% sure the string interpolation will work but we can try that.

themarcelor
themarcelor approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@themarcelor themarcelor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@themarcelor themarcelor merged commit 402d0af into master Jul 16, 2021
@themarcelor themarcelor deleted the paulineribeyre-patch-1 branch July 16, 2021 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themarcelor themarcelor themarcelor approved these changes

Assignees
No one assigned
Labels
test-apis-auditServiceTest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulineribeyre @themarcelor