Fix _db_setup_job.tpl #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an issue with db_setup_job that arises when script fails on any of the steps after database creation and get stuck on "database exists" step but fail to connect using saved credentials.
Fix a left "fi' after a previous fix
|
Merging this PR to a local branch so we can do some more testing, but this looks like a good change, thanks @andrzejgrzelak |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue with db_setup_job that arises when script fails on any of the steps after database creation and then get stuck on "database exists" step but fails to connect using saved credentials.
Now script checks both if database exists and if credentials are properly set, if any of those things is not right then it proceeds to database setup step.
Link to JIRA ticket if there is one:
New Features
Breaking Changes
Bug Fixes
Fixed a bug in which _db_setup_job gets stuck in a permanent error unless database of a related service is removed
Improvements
Dependency updates
Deployment changes