Fix/discovery load order wrong #1676
Open
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-burt-uch
force-pushed
the
fix/discovery-load-order-wrong
branch
from
45dba3f to
8011096
Compare
Adds "cache" to save response from the all studies batch so we can ignore the response from the smaller batch request in cases where the all studies batch returns before the smaller batch.
k-burt-uch
force-pushed
the
fix/discovery-load-order-wrong
branch
from
8011096 to
70794fc
Compare
k-burt-uch
commented
Feb 19, 2025
There was a problem hiding this comment.
I am open to other ideas.
There was a problem hiding this comment.
I think this can also be done at
data-portal/src/Discovery/index.tsx
Line 140 in 70794fc
rawStudies and studies. If studies already exists and the length of rawStudies is less then studies, means the larger batch has already been processed and we should stop processing further but to return instead.This way we can potentially skip some steps downstream.
There was a problem hiding this comment.
I'm not sure why, but studies is always null in that fetchRawStudies callback. I think the scope of the callback function is still holding the old component's studies
You can see this behavior here: demo/logging-studies
But yeah, the studies prop is always null during the fetchRawStudies request and callback :(
|
Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one:
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes