Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to the changes in godot download page #698

Merged

Conversation

Jeffrey04
Copy link
Contributor

@Jeffrey04 Jeffrey04 commented Jun 13, 2024

This is a minor patch to fix godot installation with umake. Long term fix would be introducing a proper html parser but for now this fix will do.

@LyzardKing LyzardKing self-assigned this Jun 14, 2024
@Jeffrey04
Copy link
Contributor Author

hmm the asset logo url is changed again, let me fix it

Copy link
Collaborator

@LyzardKing LyzardKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Change the regex to href=\"?([^\s]+\.zip) since we don't need the rest of the line parsed

@Jeffrey04
Copy link
Contributor Author

Jeffrey04 commented Jun 27, 2024

Looks good. Change the regex to href=\"?([^\s]+\.zip) since we don't need the rest of the line parsed

done

@LyzardKing LyzardKing merged commit 425268c into ubuntu:master Jun 27, 2024
3 checks passed
@LyzardKing
Copy link
Collaborator

Merged. Thank you for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants