Fix and update for Eclipse

[rockwalrus]

There seems to have been a recent change to Eclipse's downloads page that broke downloading. HTTPS doesn't seem to be supported anymore, and the r parameter was renamed to mirror_id. This commit also changes the URL to point at Mars instead of Luna. (#120)

[didrocks]

Hey, thanks for working on this! And welcome to Ubuntu Make! :)

I can happily still downloads Eclipse Luna and have tests passing here, I wonder if it's not a question of mirrors (that already stroke us in the past). Also our central test factory seems to show that all tests are passing: https://jenkins.qa.ubuntu.com/job/udtc-trusty-tests/1740/. That seems to confirm it if it's reliably broken for you (maybe this mirror removed Luna?)

Anyway, as told in other PR and bugs, I'm happy to move to Mars, so thanks for this! Here are 2 comments before merging it though:

1. I'm really willing to have as many frameworks downloading over https as possible (at least, when fetching the checksum, so that you can ensure what you download is what upstream really intended to have you running). It seems though (for me), that it works over https with your branch. Do you mind giving a double check? Can be a temporary snaffu or maybe again some mirrors disparities? (even when using mirror_id?)

2. the medium tests needs to be adapted. We ship fake assets in tests/data/server-content/www.eclipse.org/. Do you mind having a look and refreshing them to match the Mars urls? I don't think the assets themselves needs to change.
   You can ensure the medium tests still works by running:
   ./runtests tests/medium/test_ide.py:EclipseIDEInContainer (this is using docker containers)
   You can as well run the large tests (which really does an install on your system), by running:
   ./runtests tests/large/test_ide.py:EclipseIDETests

3. I'm happy to merge your changes with 1) and 2) done. I would really like in a second step though that we remove any "Mars" mention in the framework, and proceed with something similar than other frameworks and the Ubuntu Make promise: always download latest stable IDE from upstream, as we do for Android Studio and others).
   That would mean find a download page (over https), that we parse giving downloading urls for latest upstream version and a checksum (if the download isn't over https). We support that quite easily in the framework like in the Android Studio case. No pressure, but once 1) and 2) are done and I merge your PR, are you interested in working on this?

For any of those, if you need any guidance/help do not hesitate to ask, I'm more than happy helping you getting this PR in!
Thanks again for your contribution, keep me posted ;)

[didrocks]

Hey,

do you need any help with my suggestions? I'm happy to give a hand if needed or if you are stuck on anything :)

Cheers,

[MABISOFT]

I will do my best for observing all those resquest and applying helps if it needed.thanks

[didrocks]

awesome, keep me posted! :)

[rockwalrus]

Not stuck on anything, just busy. :) It looks like the HTTPS being broken
was only a temporary glitch, fortunately. I'll make the requested changes
and run the tests today.

Rockwalrus

On Mon, Sep 7, 2015 at 5:44 AM, Didier Roche [email protected]
wrote:

awesome, keep me posted! :)

—
Reply to this email directly or view it on GitHub
#145 (comment).

[didrocks]

hey @rockwalrus! I hope you have a more relaxed schedule nowdays ;)

Now that I just cut a release, I think it's time to update to Mars! Do you think you are going to get any time to work on this?

[didrocks]

I'm closing this PR now as we have a refactoring in latest release enabling to always get the update from latest version!