Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the fonts configuration from a default desktop installation #72

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

seb128
Copy link
Contributor

@seb128 seb128 commented Sep 1, 2022

We need at least the URW fonts configuration for correct PDF rendering as
reported against firefox on #49

After discussion we decided to include the configurations provided in a
default Ubuntu desktop installation for 3.38. It's not ideal but should
help with consistency with non snaps apps and be an improvement.
Going forward we should work with fontconfig upstream on a solution
which allows use to import the system configuration instead.

We need at least the URW fonts configuration for correct PDF rendering as
reported against firefox on ubuntu#49

After discussion we decided to include the configurations provided in a
default Ubuntu desktop installation for 3.38. It's not ideal but should
help with consistency with non snaps apps and be an improvement.
Going forward we should work with fontconfig upstream on a solution
which allows use to import the system configuration instead.
@seb128 seb128 requested a review from kenvandine September 1, 2022 09:08
@seb128
Copy link
Contributor Author

seb128 commented Sep 1, 2022

I've tested the snap and the pdf example from #49 renders correctly now

Copy link
Member

@kenvandine kenvandine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kenvandine kenvandine merged commit 6f39565 into ubuntu:gnome-3-38-2004 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants