Fix remote build

[sergio-costas]

The remote build seems to put all the files in a different place than /root, so it must be taken into account.

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please check only the options that are relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Test Configuration:

• OS (please include version):
• Any other relevant environment information:

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have checked my code and corrected any misspellings

[jssotomdz]

makes sense

[jssotomdz]

@kenvandine comments

then we should be able to replace "prefix=/root/stage" in that sed with "prefix=$CRAFT_STAGE"
without the python script

sed -i "s#prefix=$CRAFT_STAGE/usr#prefix=$CRAFT_STAGE#g" $CRAFT_STAGE/usr/lib/pkgconfig/$PCFILE

if we want to use a script like this, we should put it in a shared repository and reference it in a part of it's own
like maybe github.com/ubuntu/desktop-snaps/build-scripts
the use a part to get those scripts into the build env

[sergio-costas]

Mmm... yes, I think that that would work too...

[kenvandine]

It might be useful to have a build-scripts dir under the desktop-snaps repo with convenient scripts like that so they can be reused during the builds of other snaps. @sergio-costas do you have other useful scripts like this? Or was this just created for this one use case?

[sergio-costas]

Anyway, the script should be modified to ensure that all variables have $prefix appended.

[sergio-costas]

I have this repo: https://github.com/sergio-costas/snap-build-tools I can add this script there.

[sergio-costas]

@kenvandine @jssotomdz I created a MR to add the script to snap-build-tools: sergio-costas/snap-build-tools#1