Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build windows app package on PR #203

Merged
merged 2 commits into from
May 26, 2022
Merged

Conversation

didrocks
Copy link
Member

Use for now a static rootfs, do not do any other change, and pull
everything to latest.
This ensures we can always build before merging our windows app package
and attach it to the PR to sideload, without any further change.

@didrocks didrocks force-pushed the deeng-212-build-package-on-pr branch 5 times, most recently from f07d4e3 to 6a10942 Compare May 26, 2022 07:35
Use for now a static rootfs, do not do any other change, and pull
everything to latest.
This ensures we can always build before merging our windows app package
and attach it to the PR to sideload, without any further change.
@didrocks didrocks force-pushed the deeng-212-build-package-on-pr branch from 6a10942 to 1ba569f Compare May 26, 2022 07:35
We only want a testbuild on x64 and providing AppxBundlePlatforms="x64"
is not enough.
@didrocks didrocks force-pushed the deeng-212-build-package-on-pr branch from 73a27da to f1d7c8e Compare May 26, 2022 10:44
@didrocks
Copy link
Member Author

ok, build passes and we don’t have duplicated files with the last PR. We should check in the future on how we can store a given rootfs closer to CI so that we don’t rely on cloud-images download slowliness and still be able to test the final product.

@didrocks didrocks requested a review from CarlosNihelton May 26, 2022 11:25
Copy link
Collaborator

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I'll hold my wish to have a freezed smaller image to speed up the workflow.

@didrocks didrocks merged commit 197708c into main May 26, 2022
@didrocks didrocks deleted the deeng-212-build-package-on-pr branch May 26, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants