Midterm PR

[avgagliardo]

Submission for avgagliardo

Breakdown of Required Tasks and Solutions:
https://github.com/avgagliardo/CP1-24-midterm/blob/tdd/avgagliardo/documentation/how-to-run.md#task-requirements

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[avgagliardo]

No clue why the tests are failing, they all pass locally and it lints at 10/10. I've reworked the code so many times to make the linting stop complaining that I can't tamper with the unit tests to make the automated build pass. When pytest is run against the two test_*.py files, this is what I see:

PS C:\Users\thean\schoolspace\phy410\exams\midterm-branches\tdd\CP1-24-midterm\avgagliardo\code> pytest .\test_trip.py; pytest .\test_utils.py
====================================================================================== test session starts =======================================================================================
platform win32 -- Python 3.9.6, pytest-8.3.3, pluggy-1.5.0
rootdir: C:\Users\thean\schoolspace\phy410\exams\midterm-branches\tdd\CP1-24-midterm\avgagliardo\code
plugins: anyio-4.6.0
collected 13 items

test_trip.py .............                                                                                                                                                                  [100%]

======================================================================================= 13 passed in 0.89s =======================================================================================
====================================================================================== test session starts =======================================================================================
platform win32 -- Python 3.9.6, pytest-8.3.3, pluggy-1.5.0
rootdir: C:\Users\thean\schoolspace\phy410\exams\midterm-branches\tdd\CP1-24-midterm\avgagliardo\code
plugins: anyio-4.6.0
collected 21 items

test_utils.py .....................                                                                                                                                                         [100%]

======================================================================================= 21 passed in 0.77s =======================================================================================
PS C:\Users\thean\schoolspace\phy410\exams\midterm-branches\tdd\CP1-24-midterm\avgagliardo\code>

[laserlab]

The only listing issue I see which gives you 9.98/10!!!! is:

************* Module utils
avgagliardo/code/utils.py:1:0: R0801: Similar lines in 2 files
==test_trip:[91:97]
==trip:[233:241]
            "Time (s)",
            "Latitude (°)",
            "Longitude (°)",
            "Altitude (m)",
            "Altitude WGS84 (m)"
        ]

        # Check if the raw frame has been loaded (duplicate-code)

-----------------------------------
Your code has been rated at 9.98/10

which I would say is not useful since that’s bc of your unit test. So no worries.

[laserlab]

the test fail I would say bc of issues with the relative paths. If they pass directly using pytest it’s fine. If you want pass by my office to look into it.