Determining the frequency of the peak(s)

[HeshamElsaman]

Determining the frequency of the peak(s)

Linting

• The code lints

Contents

• Added a function the determines the frequency of the peak(s) taking the median of the power spectrum as a threshold and its unit test
• Files changed: preparation.py, test_preparation.py, requirements.txt

Reviewer

• @abruns123

[HeshamElsaman]

@zbpetersbuf here, I edited the power spectrum function that you created

[HeshamElsaman]

@zbpetersbuf and also the function to calculate frequencies

[HeshamElsaman]

@zbpetersbuf I guess the only problem was that they always returned (None) because the data did not pass the equally-spacing check

[HeshamElsaman]

@zbpetersbuf what I did was to allow some tolerance in the spacing since the spacing is in float-point

[HeshamElsaman]

@zbpetersbuf maybe you can check the rest of the functions for the same issue, because I only edited those two functions

[HeshamElsaman]

@zbpetersbuf my other issue was in realizing the type of the data needed to be entered to those functions

[HeshamElsaman]

@zbpetersbuf my suggestions is that you can add more details to the docstrings to emphasize the usage of pandas.Series and that the data needs to have timestamps

[zbpetersbuf]

this error tollerance is correct good job

[laserlab]

@zbpetersbuf Can you review this since you already looked into this?

[zbpetersbuf]

shouldnt some one else do the review so they can get points for it?