-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CO2 Internation data compilation. #33
CO2 Internation data compilation. #33
Conversation
@zbpetersbuf Do you want to review this, then you can see if it fits your function |
ya ill review it |
@zbpetersbuf Please review asap |
@kylemasc917 Let's do the same approach with the NOTES file as in PR #36 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this data
there are some issues with pylons such as lines being too long but that doesn't effect the efectivness of these files, also unused pandas import that could be deleted but since it functions with our without it being there there's no deire need to delete it so good with me |
@kylemasc917 |
For this assignment all pull requests going forward should contain the following (please delete the placeholder text and add your own description)
Title
Linting
-This does pylint 10/10
Contents
Txt files containing data from an observatory on each continent from 2013 to 2023
.json compiled file of all data
python module that converts the txt data into a compiled .json
NOTES file that contains the citation and license for data
Labels and Milestones
Reviewer
Any further questions on formatting pull requests can be asked in the issues tab or on discord.
This document can be changed at any time.