Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CO2 Internation data compilation. #33

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

kylemasc917
Copy link
Contributor

For this assignment all pull requests going forward should contain the following (please delete the placeholder text and add your own description)

Title

  • CO2 International data

Linting

-This does pylint 10/10

Contents

Txt files containing data from an observatory on each continent from 2013 to 2023
.json compiled file of all data
python module that converts the txt data into a compiled .json
NOTES file that contains the citation and license for data

Labels and Milestones

  • ALL pull requests must have an attached label and Milestone before a reviewer can be assigned.

Reviewer

  • avgagliardo

Any further questions on formatting pull requests can be asked in the issues tab or on discord.
This document can be changed at any time.

@kylemasc917 kylemasc917 added the Data Anything related to data label Nov 5, 2024
@kylemasc917 kylemasc917 added this to the CO2 World Data Collection milestone Nov 5, 2024
@laserlab
Copy link
Contributor

laserlab commented Nov 5, 2024

@zbpetersbuf Do you want to review this, then you can see if it fits your function

@zbpetersbuf
Copy link
Contributor

ya ill review it

@zbpetersbuf zbpetersbuf self-requested a review November 5, 2024 19:11
@laserlab
Copy link
Contributor

laserlab commented Nov 6, 2024

@zbpetersbuf Please review asap

@laserlab
Copy link
Contributor

laserlab commented Nov 6, 2024

@kylemasc917 Let's do the same approach with the NOTES file as in PR #36

Copy link
Contributor

@zbpetersbuf zbpetersbuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this data

@zbpetersbuf
Copy link
Contributor

there are some issues with pylons such as lines being too long but that doesn't effect the efectivness of these files, also unused pandas import that could be deleted but since it functions with our without it being there there's no deire need to delete it so good with me

@SchrodingersStruggle SchrodingersStruggle merged commit 5a4578d into ubsuny:main Nov 6, 2024
0 of 2 checks passed
@SchrodingersStruggle
Copy link
Collaborator

there are some issues with pylons such as lines being too long but that doesn't effect the efectivness of these files, also unused pandas import that could be deleted but since it functions with our without it being there there's no deire need to delete it so good with me

@kylemasc917
If you'd wish to make any changes messaged here just create a quick pull request for smaller additions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Anything related to data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants